[PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn()
Ingo Molnar
mingo at kernel.org
Wed Jun 6 19:40:15 EST 2012
* Ananth N Mavinakayanahalli <ananth at in.ibm.com> wrote:
> On Wed, Jun 06, 2012 at 11:23:52AM +0200, Peter Zijlstra wrote:
> > On Wed, 2012-06-06 at 14:49 +0530, Ananth N Mavinakayanahalli wrote:
> > > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, loff_t vaddr)
> >
> > Don't we traditionally use unsigned long to pass vaddrs?
>
> Right. But the vaddr we pass here is vma_info->vaddr which is loff_t.
> I guess I should've made that clear in the patch description.
Why not fix struct vma_info's vaddr type?
Thanks,
Ingo
More information about the Linuxppc-dev
mailing list