[PATCH V3 2/5] powerpc/fsl-pci: Determine primary bus by looking for ISA node

Jia Hongtao-B38951 B38951 at freescale.com
Fri Jul 27 12:56:57 EST 2012


> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Friday, July 27, 2012 2:22 AM
> To: Jia Hongtao-B38951
> Cc: linuxppc-dev at lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472
> Subject: Re: [PATCH V3 2/5] powerpc/fsl-pci: Determine primary bus by
> looking for ISA node
> 
> 
> On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote:
> 
> > PCI host bridge is primary bus if it contains an ISA node. But not all
> boards
> > fit this rule. Device tree should be updated for all these boards.
> 
> I don't really seen any reason for this patch.  We can just use the code
> as Scott wrote it that sets fsl_pci_primary based on search for the isa
> node.
> 


I change the way of searching ISA node just because the platform driver
mechanism. Probe function of this driver will be called for each PCI
controller which means more than once. I think the Scott's way is not
perfectly match this situation. Anyway I will find a better way to solve
this by refactoring the Scott's method or using my own way.

Thanks.
-Hongtao.



More information about the Linuxppc-dev mailing list