[2/3][PATCH][upstream] TDM Framework

[Singh Sandeep-B37400]

Hi,

Please find my comment inline.

Regards,
Sandeep


-----Original Message-----
From: Tabi Timur-B04825 
Sent: Tuesday, July 24, 2012 8:13 PM
To: Singh Sandeep-B37400
Cc: linuxppc-dev at lists.ozlabs.org; Aggrwal Poonam-B10812
Subject: Re: [2/3][PATCH][upstream] TDM Framework

Singh Sandeep-B37400 wrote:

>> +int tdm_adap_send(struct tdm_adapter *adap, void **buf, int count) {
>> +       int res;
>> +
>> +       if (adap->algo->tdm_write)
>> +               res = adap->algo->tdm_write(adap, buf, count);
> 
> Why does tdm_write() return a u32?  And shouldn't 'res' also be a u32, to make tdm_write()?
> [Sandeep] tdm_write() returns number of bytes written. You are right, 
> 'res' should be declared as u32

Then it should return an unsigned int.  You should used a sized integer type only when the size really matters (e.g. hardware registers or packed fields in a structure).
[Sandeep] Agreed, will rectify.