[2/3][PATCH][upstream] TDM Framework

Tabi Timur-B04825 B04825 at freescale.com
Wed Jul 25 12:40:27 EST 2012


Michael Ellerman wrote:
> I agree these values are odd. But there's no rule that you can only use
> an enum if the values are monotonically increasing.
>
> It can still serve as helpful documentation, and reduce the number of
> places you pass a bare int around.

IMHO, an enum should only be used if

1) You are doing real type checking of the enum
2) You don't care what the actual values of each enum is

For this patch, neither is true.

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the Linuxppc-dev mailing list