[1/3][PATCH][upstream]Adding documentation for TDM

[Aggrwal Poonam-B10812]

Thanks David for the comments.

Response Inline.

Regards
Poonam

> -----Original Message-----
> From: David Laight [mailto:David.Laight at ACULAB.COM]
> Sent: Monday, July 23, 2012 6:02 PM
> To: Singh Sandeep-B37400; linuxppc-dev at lists.ozlabs.org
> Cc: Singh Sandeep-B37400; Aggrwal Poonam-B10812
> Subject: RE: [1/3][PATCH][upstream]Adding documentation for TDM
> 
> > +3. TDM has programmable slot length (8 bits or 16 bits). This can be
> > +   configured by:
> > +
> > +	#define NUM_BYTES_PER_SLOT	8
> 
> I presume you meant NUM_BITS_PER_SLOT ?
> These constants need name-space protection
> 
> > +or
> > +	#define NUM_BYTES_PER_SLOT	16
> > +
This is a mistake, documentation patch not updated with the update design.
> > +depending on the type of sample. For example the sample could be 16
> > +bit linear +or 8bit u-law encoded etc.
> > +Presently only word length of 16 is supported which is the default
> > +configuration.
> 
> For flexibility you need to allow for 8bit samples being converted as:
> 1) 8bit raw ulaw or alaw data (unchanged from line).
> 2) 8bit raw data, bit reversed, any hdlc protocol
>    is bit reversed from audio [1].
> 3) 8bit audio, converted from alaw to ulaw
> 4) 8bit audio, converted from ulaw to alaw
> 5) 16bit linear converted to/from alaw or ulaw and on a per-timeslot
> basis.
I agree. That we only support very limited samples. But We can add this in second step once the basic framework is in.
Also right now the testing infrastructure we have, we won't be able to test all these scenarios.

> 
> [1] most hdlc stuff probably can't stand the 10ms epochs though, so this
> is limited use for serious work.
Right now the framework has been customized for voice. We can keep this parameter as a sysfs knob. Please suggest.

Regards
Poonam
> 
> 	David
> 
> 
>