[PATCH 1/2] power: Define PV_POWER7P
sukadev at linux.vnet.ibm.com
Tue Jul 17 07:25:51 EST 2012
Gabriel Paubert [paubert at iram.es] wrote:
| > +#define PV_POWER7P 0x004A
| > #define PV_630 0x0040
| > #define PV_630p 0x0041
| > #define PV_970MP 0x0044
| Hmm, before this patch the PVR definitions were sorted in ascending
| numerical order, at least for the list of 64 bit processors. Your
| patch breaks this, which is not a good idea IMHO.
| For example, the 970* processors are already interspersed with other
| processors to maintain numerical order, therefore I don't see why the
| POWER7P could not be between 970GX and BE.
| Another inconsistency is that all other "plus" variants seem to
| use a lower case "p" suffix. So it would be better to use POWER7p.
Agree with both your points above. I re-sent the patches with updates.
More information about the Linuxppc-dev