[RFC PATCH v3 3/13] memory-hotplug : unify argument of firmware_map_add_early/hotplug

Dave Hansen dave at linux.vnet.ibm.com
Thu Jul 12 01:30:16 EST 2012

On 07/09/2012 03:25 AM, Yasuaki Ishimatsu wrote:
> @@ -642,7 +642,7 @@ int __ref add_memory(int nid, u64 start,
>  	}
>  	/* create new memmap entry */
> -	firmware_map_add_hotplug(start, start + size, "System RAM");
> +	firmware_map_add_hotplug(start, start + size - 1, "System RAM");

I know the firmware_map_*() calls use inclusive end addresses
internally, but do we really need to expose them?  Both of the callers
you mentioned do:

	firmware_map_add_hotplug(start, start + size - 1, "System RAM");


                        entry->addr + entry->size - 1,

So it seems a _bit_ silly to keep all of the callers doing this size-1
thing.  I also noted that the new caller that you added does the same
thing.  Could we just change the external calling convention to be

BTW, this patch should probably be first in your series.  It's a real

More information about the Linuxppc-dev mailing list