[PATCH] mtd/nand:Fix wrong usage of is_blank() in fsl_ifc_run_command
Kushwaha Prabhakar-B32579
B32579 at freescale.com
Sat Jan 28 01:20:33 EST 2012
> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Friday, January 27, 2012 6:46 PM
> To: Kushwaha Prabhakar-B32579
> Cc: linuxppc-dev at lists.ozlabs.org; linux-mtd at lists.infradead.org; Wood
> Scott-B07421; Aggrwal Poonam-B10812
> Subject: Re: [PATCH] mtd/nand:Fix wrong usage of is_blank() in
> fsl_ifc_run_command
>
> On Wed, 2012-01-18 at 09:43 +0530, Prabhakar Kushwaha wrote:
> > Freescale IFC NAND Machine calculates ECC on 512byte sector and same
> > is used in
> > fsl_ifc_run_command() during ECC status verification. Also this sector
> > is passed to is_blank() for blank checking. It is wrong at first place
> > because is_blank()'s implementation checks for Page size and OOB area
> size.
> > is_blank() should be called per page for main and OOB area
> verification.
> >
> > Variables name are redefined to avoid confusion between buffer and ecc
> sector.
> >
> > Signed-off-by: Poonam Aggrwal <poonam.aggrwal at freescale.com>
> > Signed-off-by: Scott Wood <scottwood at freescale.com>
> > Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
>
> The driver is not in 3.3-rc1, so I skip this patch.
>
This patch is squashed in Linux NAND driver patch. It will be provided by galak's tree
"NAND Machine support for Integrated Flash Controller"
http://patchwork.ozlabs.org/patch/137024/
--Prabhakar
More information about the Linuxppc-dev
mailing list