[PATCH v2 0/3] ppc32/kprobe: Fix a bug for kprobe stwu r1
Benjamin Herrenschmidt
benh at kernel.crashing.org
Wed Jan 11 11:53:19 EST 2012
On Tue, 2012-01-10 at 17:15 +0800, tiejun.chen wrote:
> Tiejun Chen wrote:
> > Changes from V1:
> >
> > * use memcpy simply to withdraw copy_exc_stack
> > * add !(regs->msr & MSR_PR)) and
> > WARN_ON(test_thread_flag(TIF_EMULATE_STACK_STORE));
> > to make sure we're in goot path.
> > * move this migration process inside 'restore'
> > * clear TIF flag atomically
>
> Ben,
>
> Is this series OK?
Not completely sorry. I was about to send you some comments a couple of
weeks ago then had to leave urgently and forgot about it, then started
rewriting your code and didn't finish :-)
I'll give you some more feedback asap, sorry about that. It's getting
there but there's a couple of things I'd like to see done a bit
differently.
Cheers,
Ben.
> Thanks
> Tiejun
>
> >
> > Tiejun Chen (3):
> > powerpc/kprobe: introduce a new thread flag
> > ppc32/kprobe: complete kprobe and migrate exception frame
> > ppc32/kprobe: don't emulate store when kprobe stwu r1
> >
> > arch/powerpc/include/asm/thread_info.h | 3 ++
> > arch/powerpc/kernel/entry_32.S | 35 ++++++++++++++++++++++++++++++++
> > arch/powerpc/lib/sstep.c | 25 +++++++++++++++++++++-
> > 3 files changed, 61 insertions(+), 2 deletions(-)
> >
> > Tiejun
More information about the Linuxppc-dev
mailing list