[RFC PATCH v2 8/9] smp: refactor on_each_cpu to void returning func

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 9 03:14:01 EST 2012

On Sun, Jan 08, 2012 at 03:32:28PM +0200, Gilad Ben-Yossef wrote:
> on_each_cpu returns the retunr value of smp_call_function
> which is hard coded to 0.
> Refactor on_each_cpu to a void function and the few callers
> that check the return value to save compares and branches.
> Signed-off-by: Gilad Ben-Yossef <gilad at benyossef.com>
> Acked-by: Peter Zijlstra <a.p.zijlstra at chello.nl>
> Reviewed-by: Michal Nazarewicz <mina86 at mina86.com>
> CC: David Airlie <airlied at linux.ie>
> CC: dri-devel at lists.freedesktop.org
> CC: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> CC: Paul Mackerras <paulus at samba.org>
> CC: Grant Likely <grant.likely at secretlab.ca>
> CC: Rob Herring <rob.herring at calxeda.com>
> CC: linuxppc-dev at lists.ozlabs.org
> CC: devicetree-discuss at lists.ozlabs.org
> CC: Richard Henderson <rth at twiddle.net>
> CC: Ivan Kokshaysky <ink at jurassic.park.msu.ru>
> CC: Matt Turner <mattst88 at gmail.com>
> CC: linux-alpha at vger.kernel.org
> CC: Thomas Gleixner <tglx at linutronix.de>
> CC: Ingo Molnar <mingo at redhat.com>
> CC: "H. Peter Anvin" <hpa at zytor.com>
> CC: x86 at kernel.org
> CC: Tony Luck <tony.luck at intel.com>
> CC: Fenghua Yu <fenghua.yu at intel.com>
> CC: linux-ia64 at vger.kernel.org
> CC: Will Deacon <will.deacon at arm.com>
> CC: Peter Zijlstra <a.p.zijlstra at chello.nl>
> CC: Arnaldo Carvalho de Melo <acme at ghostprotocols.net>
> CC: Russell King <linux at arm.linux.org.uk>

As there's only one place in the ARM code where we look at the return
value, and you've patched that away in patch 1, this looks fine.  I've
not checked for users outside of arch/arm, so:

Acked-by: Russell King <rmk+kernel at arm.linux.org.uk>


More information about the Linuxppc-dev mailing list