[RFC PATCH 0/9] Remove useless on_each_cpu return value

Gilad Ben-Yossef gilad at benyossef.com
Mon Jan 9 03:10:09 EST 2012

On Fri, Jan 6, 2012 at 3:03 PM, Peter Zijlstra <a.p.zijlstra at chello.nl> wrote:
> On Tue, 2012-01-03 at 16:19 +0200, Gilad Ben-Yossef wrote:
>> on_each_cpu() returns as its own return value the return value of
>> smp_call_function(). smp_call_function() in turn returns a hard
>> coded value of zero.
>> Some callers to on_each_cpu() waste cycles and bloat code space
>> by checking the return value to on_each_cpu(), probably for
>> historical reasons.
> hysterical raisins,, yumm! :-)
>> This patch set refactors callers to not test on_each_cpu()
>> (fixed) return value and then refactors on_each_cpu to
>> return void to avoid confusing future users.
> Seems sane enough, fwiw:
> Acked-by: Peter Zijlstra <a.p.zijlstra at chello.nl>

Thanks for the review :-)

I just sent out a V2. No changes except I've added the needed signed-off-by.


Gilad Ben-Yossef
Chief Coffee Drinker
gilad at benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388

"Unfortunately, cache misses are an equal opportunity pain provider."
-- Mike Galbraith, LKML

More information about the Linuxppc-dev mailing list