[RFC PATCH 5/9] ppc: avoid using on_each_cpu hard coded ret value

Gilad Ben-Yossef gilad at benyossef.com
Wed Jan 4 01:19:09 EST 2012

on_each_cpu always returns a hard coded return code of zero.

Removing all tests based on this return value saves run time
cycles for compares and code bloat for branches.

CC: Michal Nazarewicz <mina86 at mina86.com>
CC: Benjamin Herrenschmidt <benh at kernel.crashing.org>
CC: Paul Mackerras <paulus at samba.org>
CC: Grant Likely <grant.likely at secretlab.ca>
CC: Rob Herring <rob.herring at calxeda.com>
CC: linuxppc-dev at lists.ozlabs.org
CC: devicetree-discuss at lists.ozlabs.org
 arch/powerpc/kernel/rtas.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
index 517b1d8..829629e 100644
--- a/arch/powerpc/kernel/rtas.c
+++ b/arch/powerpc/kernel/rtas.c
@@ -850,8 +850,7 @@ int rtas_ibm_suspend_me(struct rtas_args *args)
 	/* Call function on all CPUs.  One of us will make the
 	 * rtas call
-	if (on_each_cpu(rtas_percpu_suspend_me, &data, 0))
-		atomic_set(&data.error, -EINVAL);
+	on_each_cpu(rtas_percpu_suspend_me, &data, 0);

More information about the Linuxppc-dev mailing list