[PATCH 20/21] Introduce struct eeh_stats for EEH
Gavin Shan
shangw at linux.vnet.ibm.com
Wed Feb 29 12:08:37 EST 2012
>
> > +struct eeh_stats {
> > + unsigned int no_device; /* PCI device not found */
> ...
> > + "no device =%d\n"
> ...
>
> Use %u (for all the stats), you really don't want negative
> values printed.
Yes.
> I've NFI how long wrapping these counters might take!
> If it is feasable (maybe much above 100Hz) then you
> need 64bit counters.
>
I think it's better to use "u64" here ;-)
> David
>
Thanks,
Gavin
More information about the Linuxppc-dev
mailing list