[PATCH 20/21] Introduce struct eeh_stats for EEH

Gavin Shan shangw at linux.vnet.ibm.com
Tue Feb 28 12:19:51 EST 2012


> Hi Gavin,
> 
> On Fri, 24 Feb 2012 17:38:17 +0800 Gavin Shan <shangw at linux.vnet.ibm.com> wrote:
> >
> > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
> > index 1310971..226c9a5 100644
> > --- a/arch/powerpc/include/asm/eeh.h
> > +++ b/arch/powerpc/include/asm/eeh.h
> > @@ -98,6 +98,21 @@ struct eeh_ops {
> >  	int (*configure_bridge)(struct device_node *dn);
> >  };
> >  
> > +/*
> > + * The struct is used to maintain the EEH global statistic
> > + * information. Besides, the EEH global statistics will be
> > + * exported to user space through procfs
> > + */
> > +struct eeh_stats {
> > +	unsigned long no_device;	/* PCI device not found		*/
> > +	unsigned long no_dn;		/* OF node not found		*/
> > +	unsigned long no_cfg_addr;	/* Config address not found	*/
> > +	unsigned long ignored_check;	/* EEH check skipped		*/
> > +	unsigned long total_mmio_ffs;	/* Total EEH checks		*/
> > +	unsigned long false_positives;	/* Unnecessary EEH checks	*/
> > +	unsigned long slot_resets;	/* PE reset			*/
> > +};
> 
> If this is used in only one place, there is not much point in putting it
> in a header file.
> 

Thanks, Stephen. I'll move it to eeh.c in next revision.

Thanks,
Gavin

> -- 
> Cheers,
> Stephen Rothwell                    sfr at canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/




More information about the Linuxppc-dev mailing list