[PATCH 2/2 v5] powerpc/85xx: Abstract common define of signal multiplex control for qe

[Tabi Timur-B04825]

On Wed, Feb 15, 2012 at 12:58 AM, Zhicheng Fan <B32736 at freescale.com> wrote:

> @@ -114,6 +114,24 @@ struct ccsr_guts_86xx {
>        __be32  srds2cr1;       /* 0x.0f44 - SerDes2 Control Register 0 */
>  } __attribute__ ((packed));
>
> +#ifdef CONFIG_PPC_85xx
> +

Remove this #ifdef.  It doesn't really help, and it makes things more
complicated.

> +/* Alternate function signal multiplex control */
> +#define MPC85xx_PMUXCR_QE0              0x00008000
> +#define MPC85xx_PMUXCR_QE2              0x00002000
> +#define MPC85xx_PMUXCR_QE3              0x00001000
> +#define MPC85xx_PMUXCR_QE4              0x00000800
> +#define MPC85xx_PMUXCR_QE5              0x00000400
> +#define MPC85xx_PMUXCR_QE6              0x00000200
> +#define MPC85xx_PMUXCR_QE7              0x00000100
> +#define MPC85xx_PMUXCR_QE8              0x00000080
> +#define MPC85xx_PMUXCR_QE9              0x00000040
> +#define MPC85xx_PMUXCR_QE10             0x00000020
> +#define MPC85xx_PMUXCR_QE11             0x00000010
> +#define MPC85xx_PMUXCR_QE12             0x00000008

#define MPC85xx_PMUXCR_QE(x) (0x8000 >> (x))

> +                               pr_err("mpc85xx-rdb: could not map global utilties register!\n");

No exclamation marks (!) in kernel messages.

You misspelled "utilities".

-- 
Timur Tabi
Linux kernel developer at Freescale