[PATCH] powerpc/usb: fix issue of CPU halt when missing USB PHY clock

[Liu Shengzhou-B36685]

> -----Original Message-----
> From: Benjamin Herrenschmidt [mailto:benh at kernel.crashing.org]
> Sent: Wednesday, February 15, 2012 10:31 AM
> To: Liu Shengzhou-B36685
> Cc: Pavan Kondeti; linux-usb at vger.kernel.org; linuxppc-
> dev at lists.ozlabs.org
> Subject: RE: [PATCH] powerpc/usb: fix issue of CPU halt when missing
> USB PHY clock
> 
> 
> > > > +	if (!(in_be32(non_ehci + FSL_SOC_USB_CTRL) &
> > > > +CTRL_PHY_CLK_VALID))
> > > {
> > > > +		printk(KERN_WARNING "fsl-ehci: USB PHY clock
> invalid\n");
> > > > +		return -1;
> > >
> > > Please return a proper error code. -ENODEV ?
> >
> > [Shengzhou] Ok, updated in v2, thanks.
> > >
> 
> Note that I just got a p5020ds from FSL, and with it's default
> configuration, when I build & boot current upstream with FSL USB
> support (64-bit kernel) it hangs when initializing USB.
> 
> With or without this patch.
> 
> It complains about invalid dr-mode (there's two USB nodes in the .dts
> coming from uboot, an "mph" and "dr", the former has no dr-mode
> property in the device-tree.
> 
> Is the current kernel incompatible with old device-tree's ? (that would
> be a shame...)
> 
> Cheers,
> Ben.
> 
> 
Looks like there is a bug, please try to add the patch http://patchwork.ozlabs.org/patch/141558
-Shengzhou