[PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS

Kumar Gala galak at kernel.crashing.org
Tue Sep 27 08:12:09 EST 2011


On Sep 25, 2011, at 12:06 PM, Tabi Timur-B04825 wrote:

> On Fri, Sep 23, 2011 at 2:32 PM, Anatolij Gustschin <agust at denx.de> wrote:
> 
>> diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
>> index 1b393f4..b29d4f2 100644
>> --- a/arch/powerpc/platforms/85xx/Kconfig
>> +++ b/arch/powerpc/platforms/85xx/Kconfig
>> @@ -80,7 +80,7 @@ config P1010_RDB
>>  config P1022_DS
>>        bool "Freescale P1022 DS"
>>        select DEFAULT_UIMAGE
>> -       select CONFIG_PHYS_64BIT        # The DTS has 36-bit addresses
>> +       select PHYS_64BIT       # The DTS has 36-bit addresses
> 
> I have no idea how this happened, but I wonder if it's a good idea.
> On the Freescale BSP, the default config for the P1022DS is 32-bit,
> not 36-bit, so one day we might have a 32-bit config in the upstream
> repository.
> 
> PHYS_64BIT is already covered by the defconfig.  I wonder if we should
> just delete the bad line, and let the defconfig select the address
> size.

Why, the way this patch makes it will work both with a 32-bit or 36-bit address map.   The comment should be fixed since its wrong.

- k


More information about the Linuxppc-dev mailing list