[PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver

[Olof Johansson]

Hi,

On Fri, Oct 21, 2011 at 10:33 AM, Olof Johansson <olof at lixom.net> wrote:
> On Fri, Oct 14, 2011 at 03:08:34PM -0700, tmarri at apm.com wrote:
>> From: Tirumala Marri <tmarri at apm.com>
>
> Overall this driver seems to be based on the IP vendor driver? It
> looks like a completely flexible driver that implements all possible
> combinations of everything.

After looking a little closer at the patch set, it seems that number
one thing you need to do is simplify the driver. A lot.

I suggest starting from scratch with a clean implementation, only
bringing in the pieces you need. Over time, if other vendors are using
other aspects of the same IP, they get to add those parts of the
driver when they need it.  Look at the dwc3 driver for comparison on
cleanliness, it's much cleaner than what you've posted.


-Olof