[PATCH v15 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver

Pratyush Anand pratyush.anand at gmail.com
Fri Oct 21 14:48:53 EST 2011


Hi Tirumala,

I have reviwed all the patches.
Thanks for taking my most of the diffs over your v13.
There are few thing, which are really very important like,
AHB disable check, EP Disable/Stall (have commented about them in
respective patches). I am doubtful, that how does all of usbcv test cases passes
without those modifications.
So, please have a look on those comments.
You may  add my signed-off.

Regards
Pratyush


On Sat, Oct 15, 2011 at 3:38 AM,  <tmarri at apm.com> wrote:
> From: Tirumala Marri <tmarri at apm.com>
>
> v15:
>  1. Fixed some checkpatch errors.
>  2. Added spin lock check during read-modify-write of interrupt registers
>    out side intr handlers.
>  3. Removed Kconfig var which is not used and not defined.
>
> v14:
>  1. Modifying dwc_reg_read/write functions to accepts offset as arg.
>  2. Adding spin_lock to common interrupt function.
>  3. Adding start/stop, vbus_power functions to gadget_opst struct.
>  4. Removed some unnecessary comments and prints.
>  5. op_state_str() replace with common function.
>  6. Removed some unnecessary checks from apmppc.c file.
>
> Tirumala Marri (10):
>  USB/ppc4xx: Add Synopsys DesignWare HS USB OTG Register definitions
>  USB/ppc4xx: Add Synopsys DesignWare HS USB OTG driver framework
>  USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)
>  USB/ppc4xx: Add Synopsys DWC OTG HCD function
>  USB/ppc4xx: Add Synopsys DWC OTG HCD interrupt function
>  USB/ppc4xx: Add Synopsys DWC OTG HCD queue function
>  USB/ppc4xx: Add Synopsys DWC OTG PCD function
>  USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function
>  USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and
>    Makefile
>  USB/ppc4xx:Synopsys DWC OTG driver enable gadget support
>
>  drivers/usb/Kconfig               |    2 +
>  drivers/usb/Makefile              |    1 +
>  drivers/usb/dwc/Kconfig           |   84 ++
>  drivers/usb/dwc/Makefile          |   19 +
>  drivers/usb/dwc/apmppc.c          |  355 ++++++
>  drivers/usb/dwc/cil.c             |  890 +++++++++++++
>  drivers/usb/dwc/cil.h             | 1174 ++++++++++++++++++
>  drivers/usb/dwc/cil_intr.c        |  616 +++++++++
>  drivers/usb/dwc/driver.h          |   76 ++
>  drivers/usb/dwc/hcd.c             | 2471 +++++++++++++++++++++++++++++++++++++
>  drivers/usb/dwc/hcd.h             |  416 +++++++
>  drivers/usb/dwc/hcd_intr.c        | 1477 ++++++++++++++++++++++
>  drivers/usb/dwc/hcd_queue.c       |  696 +++++++++++
>  drivers/usb/dwc/param.c           |  180 +++
>  drivers/usb/dwc/pcd.c             | 1791 +++++++++++++++++++++++++++
>  drivers/usb/dwc/pcd.h             |  139 +++
>  drivers/usb/dwc/pcd_intr.c        | 2312 ++++++++++++++++++++++++++++++++++
>  drivers/usb/dwc/regs.h            | 1326 ++++++++++++++++++++
>  drivers/usb/gadget/Kconfig        |   10 +
>  drivers/usb/gadget/gadget_chips.h |    3 +
>  20 files changed, 14038 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/dwc/Kconfig
>  create mode 100644 drivers/usb/dwc/Makefile
>  create mode 100644 drivers/usb/dwc/apmppc.c
>  create mode 100644 drivers/usb/dwc/cil.c
>  create mode 100644 drivers/usb/dwc/cil.h
>  create mode 100644 drivers/usb/dwc/cil_intr.c
>  create mode 100644 drivers/usb/dwc/driver.h
>  create mode 100644 drivers/usb/dwc/hcd.c
>  create mode 100644 drivers/usb/dwc/hcd.h
>  create mode 100644 drivers/usb/dwc/hcd_intr.c
>  create mode 100644 drivers/usb/dwc/hcd_queue.c
>  create mode 100644 drivers/usb/dwc/param.c
>  create mode 100644 drivers/usb/dwc/pcd.c
>  create mode 100644 drivers/usb/dwc/pcd.h
>  create mode 100644 drivers/usb/dwc/pcd_intr.c
>  create mode 100644 drivers/usb/dwc/regs.h
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


More information about the Linuxppc-dev mailing list