[PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems
Timur Tabi
timur at freescale.com
Fri Oct 14 02:34:17 EST 2011
Kumar Gala wrote:
>>> >> + phys_addr_t addr;
>> >
>> > Please add a comment here saying:
>> >
>> > 1) That 'addr' can be a virtual or physical address
> The code and everything else makes that clear
I'm sorry, but I have to strongly disagree here. It is *NOT* clear that a
variable of type 'phys_addr_t' can hold something that is not a physical address.
--
Timur Tabi
Linux kernel developer at Freescale
More information about the Linuxppc-dev
mailing list