[PATCH v2] powerpc: book3e: WSP: Add Chroma as a new WSP/PowerEN platform.

[Jimi Xenidis]

On Tue Oct 4 05:02:41 EST 2011, Scott Wood wrote:

Looking at your comments below, will the following be acceptable

> On 09/29/2011 09:27 PM, Jimi Xenidis wrote:
> > diff --git a/arch/powerpc/platforms/wsp/Kconfig b/arch/powerpc/platforms/wsp/Kconfig
> > index ea2811c..a3eef8e 100644
> > --- a/arch/powerpc/platforms/wsp/Kconfig
> > +++ b/arch/powerpc/platforms/wsp/Kconfig
> > @@ -1,6 +1,7 @@
> >  config PPC_WSP
> >  	bool
> >  	select PPC_A2
> > +	select GENERIC_TBSYNC
> >  	select PPC_ICSWX
> >  	select PPC_SCOM
> >  	select PPC_XICS
> > @@ -8,14 +9,20 @@ config PPC_WSP
> >  	select PCI
> >  	select PPC_IO_WORKAROUNDS if PCI
> >  	select PPC_INDIRECT_PIO if PCI
> > +	select PPC_WSP_COPRO
> >  	default n
> >  
> >  menu "WSP platform selection"
> >  	depends on PPC_BOOK3E_64

add "&& SMP"

> >  
> >  config PPC_PSR2
> > -	bool "PSR-2 platform"
> > -	select GENERIC_TBSYNC
> > +	bool "PowerEN System Reference Platform 2"
> > +	select EPAPR_BOOT
> > +	select PPC_WSP
> > +	default y

Make these "default n"

Will that address everything?
-jx

> > +
> > +config PPC_CHROMA
> > +	bool "PowerEN PCIe Chroma Card"
> >  	select EPAPR_BOOT
> >  	select PPC_WSP
> >  	default y
> 
> This is an existing problem with PSR2, but please don't hide "default y"
> in a menu (at least make it a menuconfig).
>  As is, it's not obvious from
> looking at the toplevel platforms menu that these platforms are enabled
> at all.
> 
> Further, PPC_WSP doesn't build on non-SMP (undefined references to
> boot_cpuid and get_hard_smp_processor_id in ics.c), but the platforms
> that select it don't depend on SMP.

this I can solve with 

> 
> -Scott
>