[PATCH] Fix interrupt handling in MPC8xxx GPIO driver

Felix Radensky felix at embedded-sol.com
Tue Oct 11 19:24:21 EST 2011


Interrupt handler in MPC8xxx GPIO driver is missing the call
to PIC EOI (end of interrupt) handler. As a result, at least
on 85XX systems, GPIO interrupt is delivered only once. This
patch adds the missing EOI call. Tested on custom P1022 board.

Signed-off-by: Felix Radensky <felix at embedded-sol.com>
---
 arch/powerpc/sysdev/mpc8xxx_gpio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/mpc8xxx_gpio.c b/arch/powerpc/sysdev/mpc8xxx_gpio.c
index fb4963a..d2e0e1c 100644
--- a/arch/powerpc/sysdev/mpc8xxx_gpio.c
+++ b/arch/powerpc/sysdev/mpc8xxx_gpio.c
@@ -153,6 +153,7 @@ static void mpc8xxx_gpio_irq_cascade(unsigned int irq, struct irq_desc *desc)
 	if (mask)
 		generic_handle_irq(irq_linear_revmap(mpc8xxx_gc->irq,
 						     32 - ffs(mask)));
+	desc->chip->eoi(irq);
 }
 
 static void mpc8xxx_irq_unmask(struct irq_data *d)
-- 
1.7.4.4



More information about the Linuxppc-dev mailing list