[linux-pm] [RFC PATCH v2 4/4] cpuidle: (POWER) Handle power_save=off

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Nov 30 15:52:41 EST 2011


On Wed, 2011-11-30 at 06:55 +0530, Deepthi Dharwar wrote:
> I was trying to add a return value for power_save for all arch/powepc
> idle functions but a few of them directly call *.S  routines, as they
> are asm.
> 
> What would be a good way to change the return value  for asm
> routines ?
> Do we make a change in asm only, put the return value in r3 or write a
> wrapper function which would call these asm routines and return an
> int ?

No, add li r3,0 at the end, but beware that their return point might not
be ovbvious since we often return from an interrupt which modifies the
return address ... Let me know if there's some you can't figure out and
I'll help you.

Cheers,
Ben.




More information about the Linuxppc-dev mailing list