[PATCH 2/6] powerpc/85xx: consolidate of_platform_bus_probe calls

Tabi Timur-B04825 B04825 at freescale.com
Tue Nov 29 10:42:24 EST 2011


On Thu, Nov 17, 2011 at 11:56 AM, Dmitry Eremin-Solenikov
<dbaryshkov at gmail.com> wrote:

> diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c b/arch/powerpc/platforms/85xx/p1022_ds.c
> index 00d93a4..cacb4d4 100644
> --- a/arch/powerpc/platforms/85xx/p1022_ds.c
> +++ b/arch/powerpc/platforms/85xx/p1022_ds.c
> @@ -330,10 +330,6 @@ static void __init p1022_ds_setup_arch(void)
>  }
>
>  static struct of_device_id __initdata p1022_ds_ids[] = {
> -       { .type = "soc", },
> -       { .compatible = "soc", },
> -       { .compatible = "simple-bus", },
> -       { .compatible = "gianfar", },
>        /* So that the DMA channel nodes can be probed individually: */
>        { .compatible = "fsl,eloplus-dma", },
>        {},
> @@ -343,6 +339,7 @@ static int __init p1022_ds_publish_devices(void)
>  {
>        return of_platform_bus_probe(NULL, p1022_ds_ids, NULL);
>  }
> +machine_device_initcall(p1022_ds, mpc85xx_common_publish_devices);
>  machine_device_initcall(p1022_ds, p1022_ds_publish_devices);

I don't think this is working.  I need to investigate some more to be
sure, but it looks like this is not picking up "fsl,eloplus-dma".
None of the DMA channels are being probed in the audio driver
(sound/soc/fsl_dma.c).

--
Timur Tabi
Linux kernel developer at Freescale


More information about the Linuxppc-dev mailing list