[PATCH] powerpc: Decode correct MSR bits in oops output

Josh Boyer jwboyer at gmail.com
Tue Nov 29 06:46:58 EST 2011


On Mon, Nov 28, 2011 at 2:30 PM, Scott Wood <scottwood at freescale.com> wrote:
> On 11/28/2011 10:23 AM, Josh Boyer wrote:
>> On Mon, Nov 28, 2011 at 11:04 AM, Kumar Gala <galak at kernel.crashing.org> wrote:
>>>
>>> Since you're fixing this can you add the following for CONFIG_BOOKE:
>>>
>>> MSR_GS, MSR_UCLE, MSR_PMM, MSR_CM
>>
>> Those don't exist on 4xx, so CONFIG_BOOKE doesn't seem appropriate.
>
> They're defined by book3e of ISA 2.06.

4xx existed before that, sadly (as did CONFIG_BOOKE).

> Not all bits are going to exist on all CPUs -- does 4xx use these bits
> to mean something different?

No, marked as reserved.  However, given the patch shows up in human
readable output, I don't think we want reserved bits being decoded and
showing up inadvertently.

Could introduce BOOK3E_32 to cover cases like this.

josh


More information about the Linuxppc-dev mailing list