MPIC cleanup series
Benjamin Herrenschmidt
benh at kernel.crashing.org
Mon Nov 28 10:51:24 EST 2011
Hi Kyle !
I can't reply to the patches themselves easily unfortunately as I
accidentally deleted them from my mailer :-)
Overall I really look your series. It doesn't quite apply cleanly
anymore so I'll as you for a new shoot after you address the comments
below, at which point, if you're fast enough, I'll stick it in -next :-)
Just a couple of comments on some of the patches:
- 5/10: search for open-pic device-tree node if NULL
The idea is fine, however most callers ignore the device-type and only
compare on compatible, while you replace that with a match entry that
seems to require matching on both. This is likely to break stuff. The
"type" part of te march entry should be NULL I believe.
- 9/10: cache the node
of_node_get() is your friend.
- 10/10: Makes me a bit nervous. It 'looks' right but I wouldn't bet on
Apple device-trees being sane vs. chaining. I would like a test that
doesn't do the cascade if the mpic is a primary to at least limit the
risk of messup.
Cheers,
Ben.
More information about the Linuxppc-dev
mailing list