[PATCH] powerpc: Add Initiate Coprocessor Store Word (icswx) support

Anton Blanchard anton at samba.org
Tue May 3 16:55:20 EST 2011


Hi Ben,

> My only comment (sorry Anton :-) would have been that we could lazily
> allocate the spinlock on the first use_cop() ... or do we have that
> potentially called in the wrong context ?

I worry what might happen in a threaded app. It would be a strange
thing to do, but the program may call use_cop from two threads at the
same time. In that case you could corrupt the PID/ACOP values
and leak a spinlock of memory I think.

Anton


More information about the Linuxppc-dev mailing list