[PATCH] usb:gadget: use min_t() macro instead of min()
Alan Stern
stern at rowland.harvard.edu
Tue Jun 14 00:38:56 EST 2011
On Mon, 13 Jun 2011, Tanya Brokhman wrote:
> >
> > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote:
> > > Signed-off-by: Tatyana Brokhman <tlinder at codeaurora.org>
> >
> > I need a sensible commit log for this. Why do we need to change all
> > min() to min_t() ?
> >
>
> Actually, Alan asked me to make this change in one place in dummy_hcd. I
> wasn't aware of the min_t macro before that. So when I searched the code for
> other places I found quite a few and just thought that it would be "nicer"
> to use min_t() instead of min() with casting.
> So we don't "need" to make this change. Everything works as is. This patch
> only makes the code look nicer, nothing more.
> I can elaborate the above in the commit log if you want.
The change I suggested involved replacing two typecasts with a single
min_t. All (or almost all) the places this patch touches currently
contain only one typecast, so the motivation for changing them is a lot
weaker.
Alan Stern
More information about the Linuxppc-dev
mailing list