[PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops

Josh Boyer jwboyer at linux.vnet.ibm.com
Wed Jul 13 04:04:04 EST 2011

On Tue, Jul 12, 2011 at 12:40:07PM -0500, Ayman El-Khashab wrote:
>On Fri, Jul 01, 2011 at 04:44:24PM +1000, Tony Breeds wrote:
>> All current pcie controllers unconditionally use SDR to check the link and
>> poll for reset.
>I was able to apply this patch and then modify the 460SX to
>work correctly, so I think it is fine.  There is only 1
>comment below.  So how does one supply a patch atop another
>> +static int __init ppc4xx_pciex_port_reset_sdr(struct ppc4xx_pciex_port *port)
>> +{
>> +	printk(KERN_INFO "PCIE%d: Checking link...\n",
>> +	       port->index);
>Its not a functional problem, but this printk belongs in the
>check link if anywhere rather than the reset.

I've got this queued in my tree locally.  I can make that change before
I push it out.


More information about the Linuxppc-dev mailing list