[PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

David Laight David.Laight at ACULAB.COM
Fri Jan 28 20:10:46 EST 2011

> +		if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12)
> +			     && ((unsigned long)fcb % 0x20) > 0x18)) {

You need to check the generated code, but I think you need:

    if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12))
	     && unlikely(((unsigned long)fcb % 0x20) > 0x18))

ie unlikely() around both the primitive comparisons.


More information about the Linuxppc-dev mailing list