of_flat_dt_match() helper build FAIL

Grant Likely grant.likely at secretlab.ca
Fri Jan 21 16:44:13 EST 2011


On Thu, Jan 20, 2011 at 7:15 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:
>
> /arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{'
> before 'const'
>
>  and more...
>
> This hunk is obviously bogus:
>
> +struct const char *board[] __initdata = {
> +       "MPC8313ERDB",
> +       "fsl,mpc8315erdb",
> +       NULL
> +}
> +
>
> You should at least compile test your changes :-(

I do.  Always.  Over Christmas I even set up an autotest instance to
automate a bunch of the sanity testing so I'd get better coverage, and
I always get changes into linux-next, this commit included. Sometimes
I miss a configuration though, and I apologize.  Sorry.

> Please send Linus a fix.

I wrote and pushed out the fix yesterday and I just sent Linus the pull req.

g.


More information about the Linuxppc-dev mailing list