powerpc/ptrace: Fix bug in signal handling

Michael Neuling mikey at neuling.org
Thu Feb 24 11:02:11 EST 2011


> Subject: powerpc/ptrace: Fix bug in signal handling

Maybe something more descriptive here like:
  powerpc/ptrace: remove BUG_ON when full register set not available

> In some cases during a threaded core dump not all 
> the threads will have a full register set.  This
> will cause problems when the sigkill is sent to
> the thread

Please add a description for how you are solving this.  Something like
"Solve this by putting poison values in the registers".  Similar inline
comments would be good too.

Also, I'm not convinced this is the right solution... not that I have a
have a better one to suggest :-)


> +static inline int user_regset_copyout_poison(unsigned int *pos,
> +					   unsigned int *count,
> +					   void **kbuf, void __user **ubuf,
> +					   const int start_pos,
> +					   const int end_pos)
> +{
> +	long poison_data[17] = { [0 ... 16] = 0xdeadbeefdeadbeefUL };

Why only poison 17 registers?


More information about the Linuxppc-dev mailing list