arch/powerpc/kernel/cacheinfo.c: Possible null pointer dereference

[David Binderman]

Hello there,

I just tried out cppcheck-1.47 on the linux-2.6.38-rc4 source code.

It said

[arch/powerpc/kernel/cacheinfo.c:380]: (error) Possible null pointer dereference: cache - otherwise it is redundant to check if cache is null at line 382

The source code is

    WARN_ONCE(cache && cache->level != level,
          "cache level mismatch on lookup (got %d, expected %d)\n",
          cache->level, level);

    if (!cache)

I agree with cppcheck. Suggest code rework.

Regards

David Binderman

 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20110212/2292d629/attachment.html>