[PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer

Tirumala Marri tmarri at apm.com
Tue Feb 8 05:53:25 EST 2011

dwc_read_reg32 is used nowhere throughout the code. One of dwc_read32 and
dwc_read_reg32 should be removed IMO. There was once only dwc_read_reg32. In
version 5 of your patchset I believe. Why did you add another function?
AFAIK it is not correct to store pointers in u32 because they need 8 bytes
on 64-bit archs. So it was ok with the old dwc_read_reg32.
[Marri] If u32 is 8bytes isn't pointer type would be 8bytes as well. I had
change the API to avoid type castings to register addresses.

More information about the Linuxppc-dev mailing list