[PATCH -mm 2/6] powerpc: convert little-endian bitops macros to static inline functions
akinobu.mita at gmail.com
Mon Feb 7 14:08:18 EST 2011
2011/2/7 Benjamin Herrenschmidt <benh at kernel.crashing.org>:
> On Thu, 2011-01-27 at 22:56 +0900, Akinobu Mita wrote:
>> (This patch is intended to be folded into the patch in -mm:
>> The little-endian bitops on powerpc are written as preprocessor
>> macros with the cast to "unsigned long *".
>> This means that even non-pointers will be accepted without an error, and
>> that is a Very Bad Thing.
>> This converts the little-endian bitops macros to static inline functions
>> with proper prototypes.
> No objection to the powerpc variant of the patches. What is the status
> with the wholes series tho ? Does it looks like its going to be
> accepted ? Do you expect my Ack and will merge the whole thing at once ?
The whole series now seems acceptable since I fixed two issues
that Linus found annoying. (the naming and the change of prototype)
Please give your ack if it is OK.
I should have fixed them quickly so that the series went upstream
in the last merge windows. But I couldn't because I spent some time
fixing and compile testing for a bisection hole.
> Does it break bisection unless it's merged as one single giant patch ?
I think there is no known problem that breaks bisectability by
this patch series.
More information about the Linuxppc-dev