[PATCH V2 5/6] powerpc/44x: boot wrapper: allow kernel to load into non-zero address

Josh Boyer jwboyer at linux.vnet.ibm.com
Sat Feb 5 01:07:32 EST 2011


On Tue, Feb 01, 2011 at 12:48:45PM -0600, Dave Kleikamp wrote:
>+static ibm4xx_memstart;
>+
> static void iss_4xx_fixups(void)
> {
>-	ibm4xx_sdram_fixup_memsize();
>+	void *memory;
>+	u32 reg[3];
>+
>+	memory = finddevice("/memory");
>+	if (!memory)
>+		fatal("Can't find memory node\n");
>+	getprop(memory, "reg", reg, sizeof(reg));
>+	if (reg[1] || reg[2])

Wouldn't this test allow for a faulty device tree that specified a 0
size (0x0 in reg[2])?  Maybe just check reg[2] for non-zero instead?

josh


More information about the Linuxppc-dev mailing list