[PATCH 3/6] 44x: Removing dead CONFIG_PPC47x
Benjamin Herrenschmidt
benh at kernel.crashing.org
Thu Dec 1 07:20:07 EST 2011
On Wed, 2011-11-30 at 06:43 -0500, Josh Boyer wrote:
>
> That doesn't look right. The code is there doing something, why is it
> just being removed? I would think the change would be to use
> CONFIG_PPC_47x?
>
> Or if the code there isn't needed any longer, the changelog should say
> why.
Ah right, I tripped on this one too when reviewing then figured it out
but I agree, the changelog should be clearer.
If you notice, the original ifdef was in a function that is only ever
used on 44x. There's a separate function that handles 47x. I suppose
this is a leftover of the initial port which somebody forgot to remove.
So the patch is fine, but yes, the changelog could be made clearer.
Cheers,
Ben.
More information about the Linuxppc-dev
mailing list