[PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

[Kumar Gala]

On Aug 10, 2011, at 9:41 AM, Wolfgang Grandegger wrote:

> On 08/10/2011 04:15 PM, Robin Holt wrote:
>> On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote:
> ...
>> Done, except the
>>>          compatible = "fsl,p1010-flexcan", "fsl,flexcan";
>> 
>> line is
>> 	compatible = "fsl,flexcan", "fsl,flexcan-p1010";
> 
> IIRC, there order is more to less specific, e.g. for I2C:
> 
>  compatible = "fsl,mpc5200-i2c", "fsl-i2c"
> 
> ...
> 
>>> Please also correct the node names (not using the number suffix).
>> 
>> So the node names should be
>> 		can at 1c000 {
>> 		can at 1d000 {
>> correct?
> 
> Yes, just have a look how other node names are constructed, e.g. for
> sata, serial, rtc, etc.:
> 
>  $ grep serial@ *.dts
>  ...
>  pdm360ng.dts:		serial at 11000 {
>  pdm360ng.dts:		serial at 11100 {
>  pdm360ng.dts:		serial at 11200 {
>  pdm360ng.dts:		serial at 11300 {
>  pdm360ng.dts:		serial at 11400 {
>  pdm360ng.dts:		serial at 11600 {
>  pdm360ng.dts:		serial at 11800 {
>  pdm360ng.dts:		serial at 11B00 {
>  ...
> 
> Wolfgang.

Agree w/Wolfgang here, can at 1c000, can at 1d000 is what we should use.

- k