[RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.
Robin Holt
holt at sgi.com
Tue Aug 9 21:40:43 EST 2011
On Tue, Aug 09, 2011 at 09:11:33AM +0200, Wolfgang Grandegger wrote:
> > + return &p1010_rdb_system_clock;
>
> Just returning fsl_get_sys_freq() here would already be fine. I'm also
> missing the factor of two here:
>
> return fsl_get_sys_freq() / 2; ????
I am working on the other comments right now as well, but this one
brought up a good question. The old algorithm in the original freescale
patches I started with actually did, essentially:
...clock.freq = DIV_ROUND_CLOSEST(fsl_get_sys_freq() / 2, 1000) * 1000
The end result was before:
...clock.freq=0x0bebc200
After:
...clock.freq=0x0bebc1fe
Is that rounding relavent?
Thanks,
Robin
More information about the Linuxppc-dev
mailing list