[PATCH net-next-2.6 1/2] gianfar: Clean up implementation of RX network flow classification

David Miller davem at davemloft.net
Tue Apr 12 06:29:09 EST 2011


From: Ben Hutchings <bhutchings at solarflare.com>
Date: Sat, 09 Apr 2011 00:45:11 +0100

> This code was cribbed from niu, so gfar_set_hash_opts() begins by
> converting the ethtool flow class code into a class code for Sun
> Neptune hardware, then does the same thing again for the hardware it's
> really dealing with.  It may also return -1 (-EPERM) for some
> unhandled ethtool flow class codes.
> 
> Remove the useless code and definitions, and fix the error code.
> 
> Signed-off-by: Ben Hutchings <bhutchings at solarflare.com>
> ---
> This isn't even compile-tested, since it can only be built for some
> PowerPC SoCs.  Could someone on ppc-dev check that this won't break the
> driver?

I'm applying this, it looks so trivial to me that I'm willing to take
the build risk :-)

Thanks.


More information about the Linuxppc-dev mailing list