platform_driver/of_platform_driver compile warning in fsldma.c

Ira W. Snyder iws at ovro.caltech.edu
Sat Apr 9 01:32:46 EST 2011


On Fri, Apr 08, 2011 at 04:12:13AM -0500, Kumar Gala wrote:
> Grant,
> 
> I'm being lazy, can you give any quick insight on the following compile warning:
> 
> drivers/dma/fsldma.c:1457:2: warning: initialization from incompatible pointer type
> drivers/dma/fsldma.c: In function 'fsldma_init':
> drivers/dma/fsldma.c:1468:2: warning: passing argument 1 of 'platform_driver_register' from incompatible pointer type
> include/linux/platform_device.h:124:12: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
> drivers/dma/fsldma.c: In function 'fsldma_exit':
> drivers/dma/fsldma.c:1473:2: warning: passing argument 1 of 'platform_driver_unregister' from incompatible pointer type
> include/linux/platform_device.h:125:13: note: expected 'struct platform_driver *' but argument is of type 'struct of_platform_driver *'
> 

The "struct of_platform_driver" needs to be changed to a
"struct platform_driver". Just remove the "of_" prefix, the structure
initialization is correct. I sent a patch for this yesterday to LKML. The
title is: fsldma: fix build warning caused by of_platform_device changes

Ira


More information about the Linuxppc-dev mailing list