[PATCH] powerpc/book3e: Fix extlb size

Kumar Gala galak at kernel.crashing.org
Tue Apr 5 22:41:57 EST 2011


On Apr 5, 2011, at 1:28 AM, Michael Ellerman wrote:

> The calculation of the size for the exception save area of the TLB
> miss handler is wrong, luckily it's too big not too small.
> 
> Rework it to make it a bit clearer, and also correct. We want 3 save
> areas, each EX_TLB_SIZE _bytes_.

Where does the 3 come from?  I have a guess, and think its possible we (FSL) want 4?

> 
> Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
> ---
> arch/powerpc/include/asm/paca.h |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/paca.h b/arch/powerpc/include/asm/paca.h
> index ec57540..f7aa4fd 100644
> --- a/arch/powerpc/include/asm/paca.h
> +++ b/arch/powerpc/include/asm/paca.h
> @@ -106,7 +106,7 @@ struct paca_struct {
> 	pgd_t *pgd;			/* Current PGD */
> 	pgd_t *kernel_pgd;		/* Kernel PGD */
> 	u64 exgen[8] __attribute__((aligned(0x80)));
> -	u64 extlb[EX_TLB_SIZE*3] __attribute__((aligned(0x80)));
> +	u64 extlb[3][EX_TLB_SIZE / sizeof(u64)] __attribute__((aligned(0x80)));
> 	u64 exmc[8];		/* used for machine checks */
> 	u64 excrit[8];		/* used for crit interrupts */
> 	u64 exdbg[8];		/* used for debug interrupts */
> -- 
> 1.7.1
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev



More information about the Linuxppc-dev mailing list