[PATCH 15/15] powerpc: Improve prom_printf()

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Apr 5 16:53:54 EST 2011


On Tue, 2011-04-05 at 08:47 +0200, Segher Boessenkool wrote:
> Hi Ben,
> 
> > +		case 'd':
> > +			++q;
> > +			vs = va_arg(args, long);
> 
> 'd' takes an int, not a long.

Oops :-) Indeed ... copy/lpaste bogon I think

> > +			if (vs < 0) {
> > +				prom_print("-");
> 
> RELOC()?

Interesting, I had that bug and fixed it in the "ld" case and not the
"d" case :-)

Thanks !

Cheers,
Ben.



More information about the Linuxppc-dev mailing list