[PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

David Brownell david-b at pacbell.net
Thu Sep 30 20:46:25 EST 2010


--- On Thu, 9/30/10, Mingkai Hu <Mingkai.hu at freescale.com> wrote:

> From: Mingkai Hu <Mingkai.hu at freescale.com>
> Subject: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

NAK.

We went over this before.

  The bug is in your SPI master controller driver,
and the fix there involves mapping large reads
 into multiple smaller reads.  (Example, 128K
read as two 64K reads instead of one of 128K.

It's *NEVER* appropriate to commit to patching all
upper level drivers in order to work around bugs
in lower level ones.  The set of such upper level
drivers that may need bugfixing is quite large,
most will never be used with your buggy controller
driver, and all such patches will need testing (but
the test resources are probably not available).

Whatever SPI controller driver you're working with
is clearly buggy ... but not unfixably so.

DO NOT head down the path of requiring every SPI
device driver to include workarounds for this odd
little SPI master driver bug.

- Dave









More information about the Linuxppc-dev mailing list