[PATCH] spi_mpc8xxx: issue with using definition of pram in Device Tree

Scott Wood scottwood at freescale.com
Sat Sep 25 01:07:35 EST 2010


On Fri, 24 Sep 2010 01:10:06 -0600
Grant Likely <grant.likely at secretlab.ca> wrote:

> On Thu, Sep 16, 2010 at 09:05:03AM +0200, christophe leroy wrote:
> > This patch applies to 2.6.34.7 and 2.6.35.4
> > It fixes an issue during the probe for CPM1 with definition of parameter ram from DTS
> > 
> > Signed-off-by: christophe leroy <christophe.leroy at c-s.fr>
> 
> I'm sorry, I don't understand the fix from the given description.
> What is the problem, and why is cpm_muram_alloc_fixed() the wrong
> thing to call on CPM1?  Does CPM2 still need it?

I don't see how cpm_muram_alloc_fixed() can be used safely at all.  If
you need a fixed address, it shouldn't be part of the general
allocation pool, or something else might get it first.

-Scott



More information about the Linuxppc-dev mailing list