[PATCH v1 1/4] PPC4xx: Generalizing ADMA driver modifications

Dan Williams dan.j.williams at intel.com
Fri Sep 24 08:51:45 EST 2010

On 9/23/2010 3:44 PM, Tirumala Marri wrote:
>> Did you look at this changelog before sending?  It just deletes 4000
>> lines of code??
> [Marri] The reason I have to send it in different file is the size of the
> patch.
> There seem to be issue with patch sizes 200k or more.

Read the rest of what I wrote:

> Moving and renaming code in one patch makes it very difficult to verify
> the result.  When generalizing code the first thing I want to see with a
> very quick glance at the patch(es) is that the existing implementation
> is not harmed.  One way to go about this is to first identify the
> portions of existing code that you want to reuse in your driver and the
> pieces that are truly ppc440spe specific.  Move the ppc440spe pieces to
> their own file (get this reviewed and approved by the ppc440spe
> authors).  The remaining code in adma.c will be assumed generic.  You
> can then have another patch to do a simple s/ppc440spe/ppc4xx/ in adma.c
> (no other logic changes or code movement).  Then you can introduce your
> ppc460ex unique implementation that calls into adma.c.

The patch would not be so large if you leave the existing code where it 
is and move the implementation specific pieces to their own file.


More information about the Linuxppc-dev mailing list