[PATCH 2/2] powerpc/watchdog: allow the e500 watchdog driver to be compiled as a module

Timur Tabi timur at freescale.com
Tue Sep 21 01:51:37 EST 2010


On Fri, Sep 17, 2010 at 7:37 PM, Josh Boyer <jwboyer at gmail.com> wrote:
>>  config BOOKE_WDT
>> -       bool "PowerPC Book-E Watchdog Timer"
>> +       tristate "PowerPC Book-E Watchdog Timer"
>>        depends on BOOKE || 4xx
>>        ---help---
>> +         Watchdog driver for PowerPC e500 chips, such as the Freescale
>> +         MPC85xx SOCs.
>> +
>
> Again, used for more than e500.  That || 4xx in the depends statement
> right above your addition isn't there for fun :).

Does this mean that this comment which is already in the driver is
wrong?  It alludes that "Book-E" is synonymous with "e500".

/* If the kernel parameter wdt=1, the watchdog will be enabled at boot.
 * Also, the wdt_period sets the watchdog timer period timeout.
 * For E500 cpus the wdt_period sets which bit changing from 0->1 will
 * trigger a watchog timeout. This watchdog timeout will occur 3 times, the
 * first time nothing will happen, the second time a watchdog exception will
 * occur, and the final time the board will reset.
 */

#ifdef	CONFIG_FSL_BOOKE
#define WDT_PERIOD_DEFAULT 38	/* Ex. wdt_period=28 bus=333Mhz,reset=~40sec */
#else
#define WDT_PERIOD_DEFAULT 3	/* Refer to the PPC40x and PPC4xx manuals */
#endif				/* for timing information */

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the Linuxppc-dev mailing list