[PATCH 1/2] powerpc: export ppc_tb_freq so that modules can reference it

Tabi Timur-B04825 B04825 at freescale.com
Sun Sep 19 03:55:28 EST 2010

Josh Boyer wrote:
> This is a new symbol being exported, not
> one that has been exported for years.

Except that Ben says that I should change ppc_proc_freq from EXPORT_SYMBOL to 
EXPORT_SYMBOL_GPL as well.  In a sense, we're in a catch-22.  We have three 

1. We *arbitrarily* change ppc_proc_freq from EXPORT_SYMBOL to 
EXPORT_SYMBOL_GPL, so that the two symbols are exported the same way

2. We GPL-export only ppc_tb_freq and leave ppc_proc_freq as-is, but then it 
looks dumb.

3. We export ppc_tb_freq the same way we're exporting ppc_proc_freq, 
providing the most options and maintaining consistency.

I just don't see how options #1 or #2 are better than #3, and so far the only 
explanations I've heard are along the lines of "we just like it that way".

Obviously, Linus thinks it's okay to allow some non-GPL modules, otherwise he 
would have long ago changed all EXPORT_SYMBOLs to EXPORT_SYMBOL_GPL.  I'm 
just capitalizing on that mindset.

Timur Tabi
Linux kernel developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20100918/cd832523/attachment.html>

More information about the Linuxppc-dev mailing list