[PATCH 01/15] ppc: fix return type of BUID_{HI,LO} macros

Scott Wood scottwood at freescale.com
Fri Sep 17 09:04:01 EST 2010

On Thu, 16 Sep 2010 17:54:46 -0500
Linas Vepstas <linasvepstas at gmail.com> wrote:

> Acked-by: Linas Vepstas <linasvepstas at gmail.com>
> I'm guessing this worked up til now because the rtas_call function prototype
> was telling compiler to cast these to 32-bit before passing them as args.
> (and since these would still get passed as one arg per 64-bit reg, it
> still wouldn't go wrong.)
> What I'm wondering about is why there was no compiler warning about an
> implicit cast of a 64-bit int to a 32-bit int?  Surely, this is something that
> should be warned about!

-Wconversion enables this.

There'd be a lot of false positives to squash with that enabled --
and it might not be worth the resulting explosion in casts.


More information about the Linuxppc-dev mailing list