[PATCH] hvc_console: fix dropping of characters when output byte channel is full

Scott Wood scottwood at freescale.com
Wed Sep 15 06:05:39 EST 2010

On Tue, 14 Sep 2010 20:44:10 +0100
Alan Cox <alan at lxorguk.ukuu.org.uk> wrote:

> > Yes, hvc_push() reschedules.  It doesn't sit in a tight loop burning
> > electrons!
> > 
> > Can we do something safer&smarter here?
> Its a printk handler - better to lose the bytes than hang the box. I
> think the current code is probably right.

Losing the bytes is unacceptable.  Even if an hvc backend erroneously
returns zero on a permanent error, the timeout should prevent hanging
the box for too long.

Though I suspect the right answer for us may be "don't use the hvc


More information about the Linuxppc-dev mailing list